Apply labels from left to right in relabel #2189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kobzol
approved these changes
Sep 30, 2025
| let mut add = BTreeSet::new(); | ||
| let mut remove = BTreeSet::new(); | ||
|
|
||
| for delta in deltas { |
There was a problem hiding this comment.
Just a note to myself: this implementation means that doing +foo -foo -foo will actually remove foo from the issue. This is probably useful for something like alias -foo, where alias does +foo -foo.
There was a problem hiding this comment.
Yeah, and it also means that +foo +foo -foo does nothing (+foo +foo -> +foo and +foo -foo cancels each other out).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed in #2172 and in #t-compiler/contrib-private > RFC: triagebot parsing command aliases the way labels are applied in relabel is weird when the same label is used multiple times.
This PR makes the behavior more user friendly by pre-computing a "final state" where all the label deltas are applied from left to right, meaning that
+label -label/-label +labelwould cancel each other instead of using the issue state.Best reviewed commit by commit.